search

SrinivasMushnoori / repex

An implementation of the RepEx package as an application written in the EnTK API
MIT License
2 stars 2 forks source link

Use "with open" to open and read energy data from replicas instead of f.open() #19

Closed SrinivasMushnoori closed 5 years ago

SrinivasMushnoori commented 5 years ago

In the Exchange method file, we are currently using f.open() to open and read files. A few comments:

1) This should not even be in the user-facing exchange method description since it pertains to internal file handling.

2) with open is simply a better way to handle files.

Now, point 2 can be handled easily. Point 1 will need separation of the Exchange method into a "translator" component and an exchange method component.

SrinivasMushnoori commented 5 years ago

Addressed, pushed to devel.

https://github.com/SrinivasMushnoori/repex/commit/c49c26252789987a7ffdd2c5eedb5d4e77c5dcc1