search

SrinivasMushnoori / repex

An implementation of the RepEx package as an application written in the EnTK API
MIT License
2 stars 2 forks source link

Exchange Task is not getting triggered, possibly an overload #33

Closed SrinivasMushnoori closed 5 years ago

SrinivasMushnoori commented 5 years ago

https://github.com/SrinivasMushnoori/repex/commit/9071a0742f89501255f2cd9ec680a06118ed92b7

The above commit results in the check_exchange method not pushing the exchange list to the exchange task. Possibly because the exchange_list name is being overloaded. Investigating.

andre-merzky commented 5 years ago

You may want to begin using pylint - it will flag warnings if a local variable overloads a parameters, etc. It cannot find all errors of that type (as Python leaves you a lot of freedom here), but some, and also checks for other common error types.

pip install pylint
pylint file.py

You will initially see many warnings, mostly about coding style and conventions. Let us know if you need a pylint config file to silence some of those.

SrinivasMushnoori commented 5 years ago

This does not look like an overload. Very strange. The exchange_listis actually being returned late, somehow. Looking into it.

andre-merzky commented 5 years ago

Let me know if you want me to look into this. How do you run the code?

SrinivasMushnoori commented 5 years ago

Will do, thanks. Running short diagnostics, which are returning some conflicting information. Now I'm beginning to think we are indeed looking at the correct replica's local list, but something is going wrong in _check_resume. Will continue to look into it.

SrinivasMushnoori commented 5 years ago

As far as I am able to tell, we are triggering the exchange task now. Closing, will reopen if needed.