search

Sriparno08 / Openpedia

The Open Source Guide!
https://openpedia.netlify.app/
MIT License
77 stars 102 forks source link

Chore: Fix SVG Link in 'Beginner-Friendly Repos' Page #394

Closed Sriparno08 closed 2 months ago

Sriparno08 commented 2 months ago

Category

Description

We need to fix a broken SVG link in the 'Beginner-Friendly Repos' page.

Step 1: Go to client/pages/beginner-friendly-repos/index.html Step 2: Find the following link under <head>...</head>

<link rel="icon" href="./assets/short-logo.svg">

Step 3: Change it to

<link rel="icon" href="../../assets/short-logo.jpg">
GuilhermeJacobRech commented 2 months ago

Assign this issue to me, please.

Sriparno08 commented 2 months ago

You're assigned, @GuilhermeJacobRech!

GuilhermeJacobRech commented 2 months ago

Hello @Sriparno08. Following the instructions won't fix the issue because ..client/assets/short-logo.svg does not exist. Instead, there is a short-logo.png file (note the difference in the extension). I need to know how to proceed, should i create a pull request just using the .png extension in the codebase or follow the instructions, keep .svg and open a new issue about converting .png to .svg?

Sriparno08 commented 2 months ago

Good spot, @GuilhermeJacobRech.

I've modified the instructions. Now, just replace the first code block with the second code block and create a pull request.