search

Srokap / code_review

Elgg plugin for PHP code analysis and refactoring.
MIT License
6 stars 6 forks source link

Fatal error on Elgg 1.12 #11

Open Facyla opened 8 years ago

Facyla commented 8 years ago

Error on Elgg 1.12, when analyzing a subdirectory:

Fatal error: Class 'Elgg\I18n\Message' not found in /home/www/transitions2/engine/classes/Elgg/I18n/NullMessageTemplate.php on line 13

Srokap commented 8 years ago

I can't check it now, but it might actually be a core bug.

Facyla commented 8 years ago

Indeed, it is referenced here https://github.com/Elgg/Elgg/issues/8599

Srokap commented 8 years ago

Not much we can do about fatal errors caused by Elgg core, so closing this one.

Facyla commented 8 years ago

Sure, not the plugin's fault !-) If you may add a comment on the core issue that might help get it fixed ? Too bad not to be able to use this plugin because of unused broken classes... https://github.com/Elgg/Elgg/issues/8599

Srokap commented 8 years ago

Surprisingly I don't see this error anymore which is a bit odd as I remember seeing it fail. I even added it to tests to see it on different php versions and still not failing. Odd. Perhaps I changed something in the meantime and forgot about it. How about having a look at this issue again after I wrap up new version?

Srokap commented 8 years ago

@Facyla I just released version 1.0.6. Can you try it to see if problem still occurs on your end? I wasn't able to replicate it anymore.

Facyla commented 8 years ago

Well, still happening :-s
At first i thought it worked, but I had added the missing Message.php class into engine/classes/Elgg/I18n/ : with that file it works fine, but if i remove it so the core remains as on github, it still produces the error... Maybe you had added that file too ?