SrsBusiness / mp4v2

Automatically exported from code.google.com/p/mp4v2
Other
0 stars 0 forks source link

Tags::fetchGenre crashes for certain files #118

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. ./configure && make
2. ./mp4info file.m4a
3. Segmentation fault: 11

What is the expected output? What do you see instead?

I expect to see information on the file, but I get

Track   Type    Info
1   audio   alac, 248.763 secs, 5115 kbps, 192000 Hz
Segmentation fault: 11

I've tracked down the problem to line 424 of Tags.cpp. The program crashes 
because data.value is NULL and it is being dereferenced.  I have not gone 
backwards in the file parsing process to see how the genre tag is inserted into 
the CodeItemMap with NULL value, but it seems that even if the file is 
malformed the library shouldn't segfault. 

What version of the product are you using? On what operating system?

The latest svn on Mac OS X 10.7.1

Please provide any additional information below.

I have a file to illustrate the problem, but I cannot attach it here. I can 
provide it directly to a developer if needed.

Original issue reported on code.google.com by stephen....@gmail.com on 25 Aug 2011 at 1:28

GoogleCodeExporter commented 8 years ago
I'm able to fix the crash with the attached patch.

Original comment by stephen....@gmail.com on 25 Aug 2011 at 1:35

Attachments:

GoogleCodeExporter commented 8 years ago
could you email me the file in question and some code to reproduce the issue so 
I can give stuff a look?  Thanks!

Original comment by kid...@gmail.com on 5 Sep 2011 at 6:34

GoogleCodeExporter commented 8 years ago
I'll be happy to send you the file; I just need your e-mail address.  Please 
send it to me AT sbooth DOT org and I will forward the file along!

Original comment by stephen....@gmail.com on 8 Sep 2011 at 2:49

GoogleCodeExporter commented 8 years ago
Thanks for the report--should be fixed in r487.

Original comment by kid...@gmail.com on 19 Oct 2011 at 6:04