search

SscSPs / color

A single page application to view and play around with colors to find color palette
https://SscSPs.github.io/color
13 stars 29 forks source link

Updated content Readme.md. Close #51 #58

Closed BrunoLagoa closed 2 years ago

BrunoLagoa commented 2 years ago

@SscSPs I made some adjustments to Readme.

I hope you enjoy.

BrunoLagoa commented 2 years ago

If possible, would you like to add the tags to this pr, hacktoberfest, hacktoberfest-accepted. to participate in the event.

SscSPs commented 2 years ago

Hey, Thanks for the PR, looks good, Just one thing, the desktop mockup is cropped, can you align the image better so the bottom and left margins(of the app) are also visible?

SscSPs commented 2 years ago

and about the labels, read #47

BrunoLagoa commented 2 years ago

@SscSPs Hi, updated image.

SscSPs commented 2 years ago

Thanks for updating the mockup, I just noticed that you added the mockup in the public dir, public dir is built into the app, and we don't need this in the app, so I think it will be better if we put it in some other directory, "assets" can work, or "images" this directory should be in the root of the repo,

BrunoLagoa commented 2 years ago

I added it to public, it was the only place I saw the image, we can move it to assets without any problems, src/assets ?

BrunoLagoa commented 2 years ago

updated pr

SscSPs commented 2 years ago

Hey, sorry i didn't reply earlier, I actually meant creating new directory, assets sibling to src, not the one inside src, Or, "images" sibling to src,

I understand the confusion for using public, the thing is, "public" is a special directory which is bundled into the app, we don't need this image in the app, so we shouldn't add it to the bundle and increase the side needlessly. That's the reason I asked you to move it out. Same is the case with src, we should not add non essential files/blobs/directory in these 2 directories, we can create any other folder outside of these 2 for non app essential things!

I hope this makes sense, let me know if you have any questions

BrunoLagoa commented 2 years ago

Nice! good explanation. I will update the pr again. LOL

BrunoLagoa commented 2 years ago

up

SscSPs commented 2 years ago

Awesome! Looks great! Thanks for the efforts! 👍

BrunoLagoa commented 2 years ago

If possible, would you like to add the tags to this pr, hacktoberfest, hacktoberfest-accepted. to participate in the event.

SscSPs commented 2 years ago

About hacktoberfest, #47

BrunoLagoa commented 2 years ago

You don't need to worry about hacktoberfest-accepted label on your PR, the repo itself have the label, so all your PRs will show up on your dashboard in about 30 minutes of your refresh.

nice!