search

StCyr / deck-react-native

Please use https://framagit.org/StCyr/deck-react-native
21 stars 6 forks source link

View, PDF and images attachments in Deck not working #19

Closed ioscanner closed 1 year ago

ioscanner commented 2 years ago

Update: The change notes say attachments are viewable. Guess it is not working. I am testing on iOS 16.1

So far the latest update fixed the duplicate labels, Now the only thing left is to be able to view PDF and images uploaded to a card in the deck. Maybe download a document that is attached so the user can edit on the device and upload it again. Really would be nice if it opened the document in NextCloud app so you can edit there. But then they would need to upload via nextcloud then link in the Deck from Nextcloud share so you would have the path. But for now would be grateful to just view PDF and images.

Not sure if they have a way to pass a document to Nextcloud on iOS.

Thanks again great job!

StCyr commented 2 years ago

You should be able to view attachment with version 0.12.0 with iOS 16 but maybe the user-interface is not self-explanatory enough; Normally, a simple click on the attachment should download it and display it, and a long press on the "Attachments (x)" header bar should allow you to upload a new attachment.

Could you be more explanatory? What type of attachment do you try to open (pdf, png, jpg,...)? Do you have an error or does it just doesn't do anything (in which case you're maybe not using the UI properly)?

Also, I'm actively working on an improved 0.12.1 version of the UI (with icons, making it more self-explanatory where to click), which I plan to release in the coming days. So, maybe let's wait for this new version to see if things work better.

Not sure if they have a way to pass a document to Nextcloud on iOS.

Don't known either.

ioscanner commented 2 years ago

I understand how the UI works. Yes, when I long click Attachments I can upload and that works and the date is always January 20,1970 can this be the correct date of the upload?

To view I click on the attachment. It doesn't do anything. For any document. PDF, jpg, png, doc

The other thing I notice is color for the attachment name in Dark theme it is all dark grey print on a dark background making it very difficult to read. But the User that uploaded the attachment is in white. Same for Description it is dark grey print on black background. When in white theme all print is black. But the labels that are dark use dark print so those are hard to read.

I have tried from both iOS 15 and iOS 16. My ipad is still on iOS 15.

This is all the issues I have seen so far. If you have a testflight version I can test the other version if needed.

StCyr commented 2 years ago

Hi,

thanks for the update: I'm building version 0.12.1 that will probably fix your original issue.

I understand how the UI works. Yes, when I long click Attachments I can upload and that works and the date is always January 20,1970 can this be the correct date of the upload?

You're right. I'll fix this => https://framagit.org/StCyr/deck-react-native/-/issues/85

The other thing I notice is color for the attachment name in Dark theme it is all dark grey print on a dark background making it very difficult to read. But the User that uploaded the attachment is in white. Same for Description it is dark grey print on black background. When in white theme all print is black. But the labels that are dark use dark print so those are hard to read.

I've noticed and fixed that already

This is all the issues I have seen so far. If you have a testflight version I can test the other version if needed.

I don't use testflight yet...

Thanks for your testing :-)

StCyr commented 2 years ago

It turns out I'm using testflight. So, if you want to participate, just send me your email (my email address is in the README.md file).

The new version is now reviewed by Apple. It should be available tomorrow, or the day after at the latest.

ioscanner commented 2 years ago

I loaded the latest version. I can't open any attachments still, but get an error now. It gives Error: File 'file:/var/mobile/Containers/... When I click the look icon.

The Description text is still dark grey when viewing the card.

StCyr commented 2 years ago

ok, thanks for the follow-up.

I'm now publishing version 0.12.2 which fixes an issue with attachment names having blank spaces in their name; maybe that's your issue.

The Description text is still dark grey when viewing the card.

Oh... I'll have to confirm that later (don't have access to my development environment today)

ioscanner commented 2 years ago

Yes, some tests had spaces. The other thing I notice is anything else that I try to open it just goes to the name, file type,and file size with the share icon screen. As if it is trying to download the file, instead of opening the file to view.

IMG_1667482740875

StCyr commented 2 years ago

This is the issue that should be solved in 0.12.1.

if you look at the document size, you'll see that it's not correct: it's actually getting something else than the attachment (some json returned by the server or whatsoever).

version 0.12.2 should be out later today or tomorrow by the latest. So, just hold on until then and see if everything is fixed

StCyr commented 1 year ago

version 0.12.2 is released

ioscanner commented 1 year ago

Tested. Attachments work now!

Two issues I see:

I will do more testing, but so far I think that is all the major issues that impact usability.

StCyr commented 1 year ago

After you select file to upload it gives no status just sends back to card. I am sure people will go back in thinking it didn't do anything. It seems to take about 6-10 seconds or more for the attachment to show up depending on the file size. Maybe a popup that says upload complete, attachment will show shortly. Could just hold the screen while you wait for attachment to show.

Yes, There's normally a spinner but I've issues displaying it now that the attachment panel is a component of its own => https://framagit.org/StCyr/deck-react-native/-/issues/81

Description content: the text is still dark almost black when in dark mode you can't read. Text should be white like other fields when in dark mode and black when in light mode.

Confirmed => https://framagit.org/StCyr/deck-react-native/-/issues/88

StCyr commented 1 year ago

all remaining issue registered elsewhere => closing this one