StaPH-B / docker-builds

:package: :whale: Dockerfiles and documentation on tools for public health bioinformatics
GNU General Public License v3.0
182 stars 116 forks source link

adding spades version 4.0.0 #1005

Closed erinyoung closed 2 months ago

erinyoung commented 2 months ago

There's a new version of spades!

According to the release notes there are a lot more options, specifically with assembly graphs.

I copied the files from 3.15.5 and made the following changes:

  1. updated the base image to jammy
  2. updated the version arg
  3. messed with the tabs
  4. added libgomp1 to the apt-get layer
  5. added CMD layer
 $ diff spades/3.15.5/Dockerfile spades/4.0.0/Dockerfile 
1c1
< FROM ubuntu:focal as app
---
> FROM ubuntu:jammy as app
4c4
< ARG SPADES_VER="3.15.5"
---
> ARG SPADES_VER="4.0.0"
6,7c6,7
< LABEL base.image="ubuntu:focal"
< LABEL dockerfile.version="2"
---
> LABEL base.image="ubuntu:jammy"
> LABEL dockerfile.version="1"
18,24c18,26
< RUN apt-get update && apt-get install --no-install-recommends -y python3 \
<  python3-distutils \
<  wget \
<  pigz \
<  ca-certificates && \
<  apt-get autoclean && rm -rf /var/lib/apt/lists/* && \
<  update-alternatives --install /usr/bin/python python /usr/bin/python3 10
---
> RUN apt-get update && apt-get install --no-install-recommends -y \
>   python3 \
>   python3-distutils \
>   wget \
>   pigz \
>   ca-certificates \
>   libgomp1 && \
>   apt-get autoclean && rm -rf /var/lib/apt/lists/* && \
>   update-alternatives --install /usr/bin/python python /usr/bin/python3 10
27c29
< RUN wget http://cab.spbu.ru/files/release${SPADES_VER}/SPAdes-${SPADES_VER}-Linux.tar.gz && \
---
> RUN wget -q https://github.com/ablab/spades/releases/download/v${SPADES_VER}/SPAdes-${SPADES_VER}-Linux.tar.gz && \
34c36
<     PATH="${PATH}:/SPAdes-${SPADES_VER}-Linux/bin"
---
>   PATH="${PATH}:/SPAdes-${SPADES_VER}-Linux/bin"
42c44,47
< RUN spades.py --version && spades.py --test && spades.py --help
---
> RUN spades.py --version && spades.py --help
> 
> # run the supplied test
> RUN spades.py --test

Pull Request (PR) checklist:

Kincekara commented 2 months ago

Thank you for the update! It seems there are a lot of changes in spades. Deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/9668878536