StaPH-B / docker-builds

:package: :whale: Dockerfiles and documentation on tools for public health bioinformatics
GNU General Public License v3.0
187 stars 119 forks source link

adding aniclustermap 1.4.0 #1033

Closed erinyoung closed 1 month ago

erinyoung commented 1 month ago

There's a new version of ANIClusterMap!!!

There isn't a new version of fastani or skani, so just aniclustermap was updated.

I copied the files for version 1.3.0 and updated the software version arg.

I also added flags to the pip install line, but I'm unsure if I included all the relevant ones.

The full diff

$ diff aniclustermap/*/Dockerfile
1c1
< ARG ANICLUSTERMAP_VER="1.3.0"
---
> ARG ANICLUSTERMAP_VER="1.4.0"
28c28
<     pip install aniclustermap==${ANICLUSTERMAP_VER}
---
>     pip install -vv --no-cache-dir aniclustermap==${ANICLUSTERMAP_VER}

Pull Request (PR) checklist:

erinyoung commented 1 month ago

There are new features in this version according to https://github.com/moshi4/ANIclustermap/releases

Kincekara commented 1 month ago

@erinyoung I just made a PR for skani 0.2.2. Do you mind updating the skani version in this image?

erinyoung commented 1 month ago

Thank you for putting the skani Dockerfile together! I've updated the Dockerfile and readme to reflect the latest skani version.

Kincekara commented 1 month ago

Looks great, thank you! I am merging this...

Kincekara commented 1 month ago

Thank you for putting all these together. You can check the image deployment here: https://github.com/StaPH-B/docker-builds/actions/runs/10614847864