search

StaPH-B / docker-builds

:package: :whale: Dockerfiles and documentation on tools for public health bioinformatics
GNU General Public License v3.0
191 stars 119 forks source link

[Docker Workshop]: artic-ncov2019 1.2.3 #573

Closed OlintoYale closed 1 year ago

OlintoYale commented 1 year ago

Hello, I would like to select this tool, version 0.39, for the project please. Thank you, Olinto Linares-Perdomo

OlintoYale commented 1 year ago

trimmomatic version 0.39

erinyoung commented 1 year ago

I think that's awesome, but it looks like Trimmomatic v0.39 already has an 'app' and 'test' layer, and a readme.

Was there a missing feature that needed to get added?

OlintoYale commented 1 year ago

Yes, I agree with you, the main idea was getting more familiar with the topic, but it has a test/app/and the readme file. I would like to create an issue with docker-build/artic-ncov2019/1.3.0. This does not have the README.md

I open an issue on docker-build/artic-ncov2019/1.3.0

Thanks

On Mon, Jan 23, 2023 at 4:37 PM Young @.***> wrote:

I think that's awesome, but it looks like Trimmomatic v0.39 already has an 'app' and 'test' layer, and a readme.

Was there a missing feature that needed to get added?

— Reply to this email directly, view it on GitHub https://github.com/StaPH-B/docker-builds/issues/573#issuecomment-1401154060, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUISDYOBBVQKBI5I24LJLOLWT4I3TANCNFSM6AAAAAAUEMGUFI . You are receiving this because you authored the thread.Message ID: @.***>

-- IMPORTANT MESSAGE This message, including any attachments, may contain confidential information intended for a specific individual and purpose, and is protected by law.  If you are not the intended recipient, delete this message, including from trash, and notify me by telephone or email.

If you are not the intended recipient, any distributions or copying of this message, or the taking of any action based on its content is strictly prohibited.

erinyoung commented 1 year ago

This looks like a good one that needs updating. The artic workflow has a few github repos that it uses. The authors now version things better, so instead of working on version 1.3.0, what about creating a new dockerfile for version 1.2.3 of fieldbioinformatics and version 1.1.1 for primer schemes?

erinyoung commented 1 year ago

Are you still working on this or should we close this issue?

OlintoYale commented 1 year ago

Yes, I still working on that issue

Thanks

On Wed, Feb 15, 2023 at 1:11 PM Young @.***> wrote:

Are you still working on this or should we close this issue?

— Reply to this email directly, view it on GitHub https://github.com/StaPH-B/docker-builds/issues/573#issuecomment-1431967264, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUISDYOS445CCVLMLBRYM6LWXUZ7XANCNFSM6AAAAAAUEMGUFI . You are receiving this because you authored the thread.Message ID: @.***>

-- IMPORTANT MESSAGE This message, including any attachments, may contain confidential information intended for a specific individual and purpose, and is protected by law.  If you are not the intended recipient, delete this message, including from trash, and notify me by telephone or email.

If you are not the intended recipient, any distributions or copying of this message, or the taking of any action based on its content is strictly prohibited.

erinyoung commented 1 year ago

Thank you for your participation in APHL's docker workshop. I'm going to close this issue, but you are still more than welcome to create a container and push to the docker-builds repo.