StaPH-B / docker-builds

:package: :whale: Dockerfiles and documentation on tools for public health bioinformatics
GNU General Public License v3.0
182 stars 116 forks source link

adding ivar version 1.4.3 #995

Closed erinyoung closed 1 month ago

erinyoung commented 2 months ago

There's a new version of ivar!

It looks like this is mainly minor changes according to the release notes https://github.com/andersen-lab/ivar/releases/tag/v1.4.3

I, however, have made some major changes from the Dockerfile in 1.4.2:

  1. I added a builder stage where samtools, htslib, and ivar are installed
  2. There is no longer bedtools, bwa, or minimap2. I have tried using ivar's piping method, but it too slow for my purposes. If someone else uses this option, let me know and I can add them back in
  3. I added a CMD line

Pull Request (PR) checklist:

Kincekara commented 2 months ago

Thank you for putting all these together! I have no objection to removing bedtools, bwa, or minimap2. I will merge this if nobody says against it.

erinyoung commented 2 months ago

@kevinlibuit or @kapsakcj , do you use the ivar image? Do you think it'd be okay to remove bedtools, bwa, and minimap2 from it?

kapsakcj commented 2 months ago

We do use bwa & samtools within the ivar docker image, but don't use bedtools or minimap2

I'm fine either way if you want to remove all of those or keep some/all. We could make a custom image that includes everything we need if necessary.

Kincekara commented 1 month ago

Thank you for putting all this together! Deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/10308039008