StaPH-B / docker-builds

:package: :whale: Dockerfiles and documentation on tools for public health bioinformatics
GNU General Public License v3.0
182 stars 116 forks source link

add pangolin 4.3.1 and new version of pdata 1.28; minor CI update #997

Closed kapsakcj closed 2 months ago

kapsakcj commented 2 months ago

Here's the diff, I upgraded to pangolin-data 1.28 & added a test for a newly designated lineage, LK.1, to the end. Everything else is the same

$ diff pangolin/4.3.1-pdata-1.27/Dockerfile pangolin/4.3.1-pdata-1.28/Dockerfile 
12c12
< ARG PANGOLIN_DATA_VER="v1.27"
---
> ARG PANGOLIN_DATA_VER="v1.28"
189c189,199
< column -t -s, PP218754.1-usher/lineage_report.csv
\ No newline at end of file
---
> column -t -s, PP218754.1-usher/lineage_report.csv
> 
> # new lineage LK.1 that was introduced in pango-designation v1.28: https://github.com/cov-lineages/pango-designation/commit/922795c90de355e67200cf4d379e8e5ff22472e4
> # thank you Luis, Lorraine, Marcos & team from PR Sci Trust for sharing your data!
> # genome on NCBI: https://www.ncbi.nlm.nih.gov/nuccore/2728145425
> RUN datasets download virus genome accession PP770375.1 --filename PP770375.1.zip && \
> unzip PP770375.1.zip && rm PP770375.1.zip && \
> mv -v ncbi_dataset/data/genomic.fna PP770375.1.genomic.fna && \
> rm -vr ncbi_dataset/ README.md && \
> pangolin PP770375.1.genomic.fna -o PP770375.1-usher && \
> column -t -s, PP770375.1-usher/lineage_report.csv

Pull Request (PR) checklist:

kapsakcj commented 2 months ago

docker build via github actions complained that FROM and as did not have the same casing, so I updated the dockerfile to have FROM x AS app and FROM app AS test to silence the warning.

I also updated the CI check to look for the uppercase AS app and AS test so that it will pass for both casings going forward.

Small/minor update to the CI

erinyoung commented 2 months ago

I am going to

  1. merge this PR
  2. deploy this to dockerhub and quay using the tag '4.3.1-pdata-1.28'
  3. overwrite the 'latest' tag
erinyoung commented 2 months ago

You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/9670727959

kapsakcj commented 2 months ago

No worries about the CI and thanks for the quick review and deploy!