StaPH-B / titan

Public health bioinformatics repository for WDL workflows to analyze viral genomes.
GNU Affero General Public License v3.0
3 stars 1 forks source link

Differences in Pangolin2 task inputs #13

Closed jvhagey closed 3 years ago

jvhagey commented 3 years ago

Current code for task_taxonID.wdl pangolin2 task lines 119-121 looks like this:

pangolin "~{fasta}" \
--outfile "~{samplename}.pangolin_report.csv" \      
--verbose

The code for Theiagen's fork of the same task lines 111-115 looks like this:

task pangolin2 {  
input {    
File        fasta    
String    samplename    
Int         min_length=10000   
Float     max_ambig=0.5    
String    docker  
}
  command 
  <<<   
  # date and version control    
  date | tee DATE    set -e

    pangolin "~{fasta}" \      
     --outfile "~{samplename}.pangolin_report.csv" \       
     --min-length ~{min_length} \       
     --max-ambig ~{max_ambig} \      
     --verbose

We might need to consider adding --min-length and --max-ambig parameters to toolkit version to avoid differences in pangolin calls between Terra and CLI versions.