StaPH-B / titan

Public health bioinformatics repository for WDL workflows to analyze viral genomes.
GNU Affero General Public License v3.0
3 stars 1 forks source link

Match CPUs/memory task requests to cli arguments #6

Closed k-florek closed 3 years ago

k-florek commented 3 years ago

After a discussion it seems like the best way forward may be to match the task request to the cli argument since this would utilize cloud resources most effectively. It could cause issues if the workflow is run on local environments but those issues will have to be addressed as they arise, potentially with an additional configuration file.

From @jvhagey review: Ex: for Seqyclean - runtime is requesting 2 CPUs and -t (threads) is defaulted at 16. "cpus" argument should be changed to "threads" where appropriate to be clear where it is threads and where it is CPUs.

jvhagey commented 3 years ago

For each task that has CPUs as an input:

Comment when a task has been checked and edited.

k-florek commented 3 years ago

I believe I have addressed all of these points with Pull Request #12 please let me know if I have missed anything.