Closed kresp0 closed 1 year ago
Sorry for the late response and thanks for the PR.
As mentioned on Mastodon, I agree that the current screens are way to colorful and I like the idea to sticking with monochrome. However, I want to eventually replace the separate screens with pre-rendered messages with one or two half-empty screens that leave room to render text using the bitmap font that I already use for the on-screen display (showing the mode when pressing the mode button or the title of the game when it has been recognized).
This will allow to give more specific error messages that help me debug issues without asking the users to use a terminal and to update states without reloading the entire screen. Or even showing specific messages on "expected" failures, like detecting an Everdrive or EZ flash and showing something helpful instead of showing an error while the Game Boy resets after a game has been loaded.
Not yet sure if I should entirely dismis color. On one hand red error messages might be a good idea as they really pop when everything else is grayscale and I still like that colored bar that shows that the video stream is still running (it's in your version, too, as it is added there by the code).
So, while I like your screens, I will close this PR as I don't think that it is a good idea to change the look now when I already plan for another change.
I think that monochrome screens with bitmap fonts look better than the original ones, and are more in line with the GB games. https://youtu.be/h2sQPhzgeJc