search

Staartvin / Autorank-2

Autorank is a Spigot/Bukkit plugin for automatically ranking players based on requirements
Other
56 stars 61 forks source link

#740 suggested Fix for useSSL issue #741

Closed mcdaddytalk closed 4 years ago

mcdaddytalk commented 4 years ago

Suggested fix for useSSL issue

Staartvin commented 4 years ago

Hmm, I would propose that instead of putting this into the URL, you put the option of enabling SSL in config of Hikari. You should put it as a property of the datasource, instead of hardcoding it.

Staartvin commented 4 years ago

This looks good. Did you test it yourself on a MySQL server?

mcdaddytalk commented 4 years ago

Yes. Tested on a Dev MC instance pointing to a local Mysql server. Tested different values as well for useSSL: true|false|blarg true failed because I do not have SSL set up but it did indicate a difference is settings. false passed blarg passed as it is not boolean and default "false" was used