Closed heppu closed 7 years ago
Although package generics maintains the highest level of standards around tests passing, the Travis integration is still a WIP, therefore I do not consider it a blocking issue at this time.
That said, I must still verify these changes by hand before accepting the PR.
I have to say that I really appreciate you taking time to verifying these changes by hand while CI is still in WIP considering amount of code these changes may have on impact in g.go.
It's hard work, but that's what passion is all about. I'll make the hard personal sacrifices to ensure the success of something I truly believe is the future of golang.
On Sep 26, 2016 6:23 AM, "Henri Koski" notifications@github.com wrote:
I have to say that I really appreciate you taking time to verifying these changes by hand while CI is still in WIP considering amount of code these changes may have on impact in g.go.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/StabbyCutyou/generics/pull/10#issuecomment-249533663, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdTKuzXHXzusDtgfJvVZSXTOoxSFqmUks5qt50lgaJpZM4KGWKR .
Added test cases for byte and rune to close issue #9.