search

StabbyCutyou / generics

Package generics is the true way to program generically in golang
Apache License 2.0
193 stars 9 forks source link

Aliased generics. For a better future #18

Open dlsniper opened 6 years ago

StabbyCutyou commented 6 years ago

So, I'm still in the process of reviewing your contributions, but I will say that it seems your changes have made the tests take so many hours to complete, that they simply time out.

Because performance is of the utmost concern, I'll need to look into where the degradation is coming from. Go is all about performance, and as the author of package generics, I cannot let the theoretical millions of gophers who rely on this package down.

dlsniper commented 6 years ago

I've read on the Internet that if I close and reopen the PR Travis will try again

dlsniper commented 6 years ago

Dear Maintainer,

Seeing how it's of utmost important to ensure widespread usability and testability of this package, I took the liberty to further add to the package testing suite the missing Go versions.

I hope that my actions will be rewarded with some of that sweet sweet acceptance into this select club of contributors as I'm trying to make these changes available for everyone.

Please let me know if these changes are now up to the high standards imposed by this project and if not, how I can improve my work so that this becomes part of the Source.

Thank you.

Yours truly, @dlsniper

StabbyCutyou commented 6 years ago

An additional question for the opener of the PR:

With the current build tag solution, will the go1.9 build continue to be chosen for 1.10, 1.11, 1.12, etc?

Or as commenter K Nova suggests, do we need a more robust solution?

Excited to see where this PR goes! A backwards compatible but future-thinking change is exactly the kind of fresh thinking lifeblood that package generics needs to stay alive in this competitive climate!