search

StabbyCutyou / generics

Package generics is the true way to program generically in golang
Apache License 2.0
193 stars 9 forks source link

adds tests for extra high quality generics #3

Closed nii236 closed 7 years ago

nii236 commented 7 years ago

2

StabbyCutyou commented 7 years ago

Thank you for submitting your contribution to this library.

I will review it tonight and let you know if I feel this change is in keeping with the backward compatibility promise that I and golang adhere to.

StabbyCutyou commented 7 years ago

Thank you for taking the time to submit your work into package generics.

I want you to know that I have recently accepted another PR which is now causing yours to conflict with master.

In the spirit of community driven collaboration (for which I believe the gold standard has been set by golang itself), I will allow you the chance to rebase your changes and re-submit them via this PR.

That said, I am currently working on a more thorough range of tests myself. So while I want to give you official contributor credit to this library, understand that your changes may be lost in the revised tests. However, I would promise to you that the ethos behind your tests will be carried forward into the new tests as well, and so you should not feel bad if any of your direct contributions are lost.

Package generics was designed for the community, and I want the community to feel as welcome as they do when it comes to enacting changes in golang itself.

StabbyCutyou commented 7 years ago

Hello,

Unfortunately you were not able to rebase in time get your changes recorded in the official history. I've already updated the tests substantially to increase coverage, and these changes would conflict heavily with the new version.

However, I encourage you to add any tests you feel may still be missing, and open a new PR.

Thank you again for your interest, support, and contributions to package generics!