search

StabbyCutyou / generics

Package generics is the true way to program generically in golang
Apache License 2.0
193 stars 9 forks source link

Only print for failed tests #4

Closed Merovius closed 7 years ago

Merovius commented 7 years ago

A passing test shouldn't produce any output. Use the (*testing.T).Logf methods instead of fmt.Printf.

StabbyCutyou commented 7 years ago

Thank you for submitting your contribution to this library.

I will review it tonight and let you know if I feel this change is in keeping with the backward compatibility promise that I and golang adhere to.

This also potentially conflicts with another PR currently open, and so I will need to weigh heavily which PR is more in keeping with the ethos of the library before acting.

StabbyCutyou commented 7 years ago

I have decided to accept this change. Thank you for contributing high quality code to the generics project!

I will note, however, that shortly I will be adding more tests, and so your changes may be lost in this transition. That said, I wanted to give you official credit by accepting this PR ahead of that refactor, and also let you know that I will carrying forward the design ethos espoused in this PR in my additional tests.