search

StabiBerlin / sbb-relevance-test

Specs for relevance of stabikat search
MIT License
3 stars 1 forks source link

Failed test "African American Review" #78

Closed annekauf closed 1 month ago

annekauf commented 6 months ago

After being nonplussed for days why cypress test fails whereas Ranking1 Frontend shows desired Ranking, namely "Journal entries before journal volumes" I am wondering about this:

For the test to be green the html field called 'media-type" must contain the given term. As far as I see, the html field is called 'mediatype_str_mv'. Even if this doesn't matter: the journal "African American Review" only contains 'c' in that field. Therefore, the test fails ALTHOUGH the hits are according to the right sequel: journal before journal volume. Also: second hit is digital journal - which anyway would never contain Zeitschrift (gedruckt) which would make 'gedruckt' a problem. As it would be with any digital journal, right?

Another question referring to test lines 20+23: https://github.com/StaatsbibliothekBerlin/sbb-relevance-test/blob/4ad25736a343eeb1ae40fdcb1fdf62115e2c7b62/cypress/e2e/nested.cy.js#L19

Does this mean any number of results containing 'Zeitschrift gedruckt' should be listet higher than any number of results containing 'Band einer Zeitschrift'?

annekauf commented 3 months ago

this issue has been solved by referenced commit, no?

duncdrum commented 3 months ago

@annekauf once the commit is merged it will be closed automatically. The PR is still open

annekauf commented 3 months ago

Should PR be merged? Did I miss it?

Annette Kaufmann Benutzungsabteilung, E-Services und Kommunikation Staatsbibliothek zu Berlin – Preußischer Kulturbesitz

+49 30 266 433 559 @.***

Im Rahmen der E-Mail-Kommunikation werden gegebenenfalls personenbezogene Daten verarbeitet. Unsere Hinweise zum Datenschutz finden Sie hier: http://sbb.berlin/datenschutz

Von: Duncan Paterson @.> Gesendet: Mittwoch, 17. Juli 2024 18:08 An: StaatsbibliothekBerlin/sbb-relevance-test @.> Cc: Kaufmann, Annette @.>; Mention @.> Betreff: Re: [StaatsbibliothekBerlin/sbb-relevance-test] Failed test "African American Review" (Issue #78)

@annekaufhttps://github.com/annekauf once the commit is merged it will be closed automatically. The PR is still open

— Reply to this email directly, view it on GitHubhttps://github.com/StaatsbibliothekBerlin/sbb-relevance-test/issues/78#issuecomment-2233683643, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BEE7XY2CSTE4YILFRU7Y6UTZM2JHDAVCNFSM6AAAAABHFVLEC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGY4DGNRUGM. You are receiving this because you were mentioned.Message ID: @.**@.>>

duncdrum commented 3 months ago

you should rebase on main first. If everything is green on github, we need to check ranking1 with the modifications of the yaml.