search

Stability-AI / StableSwarmUI

StableSwarmUI, A Modular Stable Diffusion Web-User-Interface, with an emphasis on making powertools easily accessible, high performance, and extensibility.
MIT License
4.49k stars 360 forks source link

[Feature Request] Add ProRes to SwarmSaveAnimationWS #305

Closed githubarooski closed 5 months ago

githubarooski commented 5 months ago

I think your code change would be something like this https://github.com/Stability-AI/StableSwarmUI/blob/master/src/BuiltinExtensions/ComfyUIBackend/ExtraNodes/SwarmComfyExtra/SwarmSaveAnimationWS.py

        elif format == "prores":
            args += [ "-n", "-c:v", "prores_ks", "-profile:v", "3", "-pix_fmt", "yuv422p10le"]
            ext = "mov"
            type_num = 7

but I tried adding this and it started only outputting JPEG files instead of MOV files, so clearly there is more involved with the change.

While it's probably more common to rely on VHS to output prores, it seems like a simple enough change to support it in Swarm for the edge case that would use it. Otherwise you need to always combine SwarmSaveAnimation with VHS Video Combine

mcmonkey4eva commented 5 months ago

Added, though note that my browser (Firefox) wasn't willing to render it on page, so I'm not 100% confident on it, but the output video file plays in VLC so it's probably good.