Stability-AI / api-interfaces

Interface definitions for API interactions between components
140 stars 78 forks source link

feat: Add Asset Query Endpoint to projects proto #54

Closed arsenetar closed 1 year ago

arsenetar commented 1 year ago
arsenetar commented 1 year ago

The Request field is added to ProjectAsset in another branch, which has some auxiliary changes to sort out some of the issues with including it as things are now. This change here does not need the additional modifications so this PR intends to skip adding that as those changes are going to need a bit more review to make sure functionality is not broken. Those changes are over in https://github.com/Stability-AI/api-interfaces/tree/as/asset-request at the moment.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

johnsabath commented 1 year ago

Tagging in @hlky to bring a DS perspective to the review

hlky commented 1 year ago

Where am I getting image generation settings from? I don't see a link between the request that produced the asset, and the ProjectAsset.

arsenetar commented 1 year ago

Where am I getting image generation settings from? I don't see a link between the request that produced the asset, and the ProjectAsset.

I noted above that it will be under ProjectAsset as request, https://github.com/Stability-AI/api-interfaces/pull/54#issuecomment-1349895944, that addition will follow in a separate PR.

As to the other questions, I think we can discuss offline, and/or share some examples.