search

Stability-AI / stable-audio-tools

Generative models for conditional audio generation
MIT License
2.55k stars 237 forks source link

Remove unused s3fs dependency #116

Open ggilder opened 2 months ago

ggilder commented 2 months ago

I noticed that it takes quite a while to download the various dependencies of s3fs during pip install, and it appears that s3fs is not actually referenced anywhere in the repo (see search). So no need to include in setup.py.

ggilder commented 2 months ago

For more context - doing pip install stable-audio-tools takes a long time downloading multiple versions of s3fs as well as its dependencies like boto3, botocore and aiobotocore, with messages like:

INFO: pip is looking at multiple versions of s3fs to determine which version is compatible with other requirements. This could take a while.
ggilder commented 1 month ago

@zqevans any opposition to this?

akx commented 1 month ago

139 is related.