StableCanvas / comfyui-client

all ComfyUI http/ws APIs. support NodeJS / Browser environments. and advanced programmable workflow.
https://stablecanvas.github.io/comfyui-client/
MIT License
60 stars 10 forks source link

CLI tool #1

Closed creativewax closed 2 months ago

creativewax commented 3 months ago

i have installed your cli tool, i can not get it to work at all, am i missing something?

creativewax commented 3 months ago

Got it working, needed a few more instructions i would say, i have noticed with more complex graphs like what i have is its breaking at points

zhzLuke96 commented 3 months ago

you mentioned that the tool breaking at points when dealing with more complex graphs. Could you please provide more details on the specific issues you're encountering? This will help us better understand and address the problem.

and, You mentioned that you managed to get it working. Could you share what steps you took to resolve the initial issue? This information could be very helpful for us to include in the documentation for other users.

@creativewax thx feedback!

creativewax commented 3 months ago

So to get it to work i had to use npx before it, not sure why

creativewax commented 3 months ago

generate.zip But it would not work with the large graph i have, the order of nodes was messing up, so i had ChatGPT rewrite it a few times over and got to this, now builds the file but its not working because of custom nodes etc, i would of rewrote it myself but pushed on time today and didn't mind GPT hacking it together ha

zhzLuke96 commented 3 months ago

generate.zip But it would not work with the large graph i have, the order of nodes was messing up, so i had ChatGPT rewrite it a few times over and got to this, now builds the file but its not working because of custom nodes etc, i would of rewrote it myself but pushed on time today and didn't mind GPT hacking it together ha

Coooool, thanks for your code. I will review it shortly.

You mentioned that "custom nodes are causing issues"? It shouldn't be a problem with the code generated by the CLI, right? Because, in fact, within the client, there is no difference between built-in nodes and custom nodes in ComfyUI, as they are the same in terms of interfaces.

If you are referring to the process from code to graph, I haven't implemented that part yet. It belongs to the TODOs section. One major reason is that it requires implementing the scheduling logic for nodes within the ComfyUI system (i.e., the sort logic).

zhzLuke96 commented 2 months ago

add

548f97dc279ff207e38a55f6ab63b81066d63076 499426731b5580b3130fbf5d982b3537a71fa6f9 4199047171cc8efab9f32d19b9a6d08f72d99119 15c467791a93e89c2b1632cf237f45f648525675 7ba10847d3995040e260b098b7d8ddb982e57e94 63b0d6e162c9ec532fd2aed184dd127c143fb1e3