Stabyourself / nottetris2

A mess
Do What The F*ck You Want To Public License
105 stars 26 forks source link

Initial love 0.8.0+ fixes #1

Open Mystro256 opened 7 years ago

Mystro256 commented 7 years ago

A bunch still needs to be done, but I fixed all the easy stuff for supporting love 0.8.0+. I avoided anything that would break 0.7.2 support.

The only things that need to change for 0.8.0+ would be to fix the physics stuff, font rendering issues, and love.event.push("q") has been changed to love.event.push("quit")

But that can be saved for after the physic stuff is fixed. Afterwards, I would suggest scrapping 0.7 support as it makes the code too messy.

As for the physics stuff, here's what I've noted in the changes from 0.7 to 0.8 (I have some code ready but I'm still working on it):

Also! One more thing. Can you please add a license for this? Either stick it in the tops of the source files like you did with orthorobot, or if you're feeling lazy, just throw it in the readme or make a license file. I would add one myself, but I wasn't sure if you wanted to use WTFPL or CC-BY-NC-SA.

Stabyourself commented 7 years ago

Added WTFPL as requested

Stabyourself commented 7 years ago

I'm not sure if keeping 0.7.2 support is a good idea. With how much the box2d implementation changed after 0.7.2, it's gonna be a mess to carry compatibility through the whole thing. Maybe it would be better to just go for 0.10.X support?

Mystro256 commented 7 years ago

I agree, I would kill 0.7.2. I kept it compatible with 0.8.0 onward, as nothing really significant has changed since then. Up to you if you want to only support 0.10.X.

As for "setMassFromShapes", it always returns approximately 4.5511 ish, so you can probably hard code this in, if mass is actually required.

yajo commented 4 years ago

Hi there, I'd really love to see resurrected this game and package it as a flatpak to make it available to the wider Linux gamer community.

I started it in https://github.com/flathub/flathub/pull/377 but it seems too far away from my knowledge how to pack this properly as it is. I was hoping that after this PR was merged and newer LÖVE versions were supported, it would become much easier.

Could somebody with the required knowledges please finish this? :pray: :innocent: