Stabyourself / nottetris2

A mess
Do What The F*ck You Want To Public License
105 stars 26 forks source link

Mac version has invalid CFBundleSignature and wrong PkgInfo #9

Open ryandesign opened 2 months ago

ryandesign commented 2 months ago

The Mac version available on the web site has its creator code set (in the CFBundleSignature field of its Info.plist) to Ntrs2. That's not a valid value. The creator code must be a globally unique four-character code that you have registered with Apple. If you have not registered a creator code with Apple, set this field to ????.

Creator codes were essential in Mac OS 9 and earlier because they were the way that icons and file types were associated with a program but are not particularly relevant on Mac OS X and later where the bundle identifier is used for that purpose instead so I don't think anybody registers creator codes with Apple anymore. I'm not sure they even still offer creator code registration.

The PkgInfo file needs to be updated as well. Its contents are currently LoVeLoVe. Its contents should be the concatenation of two values from the Info.plist: the four-character value of CFBundlePackageType (which should be APPL meaning application) and the four-character value of CFBundleSignature (your creator code or ???? if you don't have one). Ensure that this file is exactly eight bytes, with no trailing newline.