search

Stabzs / Angular2-Toaster

Angular2-toaster is an asynchronous, non-blocking Angular Toaster Notification library
MIT License
334 stars 93 forks source link

Extend peer dependencies to Angular 8 #188

Closed alvaro-octal closed 5 years ago

alvaro-octal commented 5 years ago

Issue description

running npm install throws the following warning:

npm WARN angular2-toaster@7.0.0 requires a peer of @angular/common@^7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular2-toaster@7.0.0 requires a peer of @angular/compiler@^7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular2-toaster@7.0.0 requires a peer of @angular/core@^7.0.0 but none is installed. You must install peer dependencies yourself.

Steps to reproduce and a minimal demo of the problem

npm install with Angular 8

Current behavior

npm install shows a couple of warning due to peer dependencies.

Expected/desired behavior

No warnings should be shown

preston commented 5 years ago

Yes please!!!

dessalines commented 5 years ago

Same.

maxailloud commented 5 years ago

Did you forget to publish to npm or is it just taking a bit of time to be updated?

Stabzs commented 5 years ago

It has just been published under version 8.0.0. Thanks everyone for your patience!

maxailloud commented 5 years ago

Perfect thank you.