Stabzs / Angular2-Toaster

Angular2-toaster is an asynchronous, non-blocking Angular Toaster Notification library
MIT License
334 stars 93 forks source link

New release for Angular 13 ? #243

Open vanackere opened 3 years ago

vanackere commented 3 years ago

Hi,

Would it be possible to make a new release of this library, compatible with angular 13 ? Currently the library works but it is required to use the --force option of npm :

Conflicting peer dependency: @angular/compiler@11.2.14
npm WARN node_modules/@angular/compiler
npm WARN   peer @angular/compiler@"^11.0.0" from angular2-toaster@11.0.1
npm WARN   node_modules/angular2-toaster
npm WARN     angular2-toaster@"11.0.1" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: angular2-toaster@11.0.1
npm WARN Found: @angular/core@13.0.1
npm WARN node_modules/@angular/core
npm WARN   @angular/core@"^13.0.1" from the root project
npm WARN   6 more (@angular/animations, @angular/cdk, @angular/common, ...)

Best regards,

nosovk commented 2 years ago

@vanackere you may use npm install --legacy-peer-deps --save for now. It will work with 12\13 Angular because actually there is everything correct inside the package, it's just new NPM behavior.

jdelaune commented 2 years ago

While we can use --legacy-peer-deps we shouldn't have to. One has to assume this package is no longer maintained, no commits for 2 years.

sistla001 commented 2 years ago

Is this package still maintained?

Stabzs commented 2 years ago

I haven't focused on this package in some time due to conflicting priorities and the fact that the feature set was stable, mature, and relatively easy to integrate with later versions of Angular.

That said, it certainly isn't a fair posture to take considering it impacts the awesome community that uses the package. Using the package should be easy and convenient. I'll get new branches cut for both Angular 12 and 13 targets.

graphicsxp commented 2 years ago

can we have it working with angular 14 ? i get the same peer dependencies errors.

coffeymatt commented 2 years ago

@Stabzs Any chance of this being updated? Still 11.0.1 on npm

assaftenen commented 2 years ago

@Stabzs Kindly asking - any update here?