Stabzs / Angular2-Toaster

Angular2-toaster is an asynchronous, non-blocking Angular Toaster Notification library
MIT License
334 stars 93 forks source link

Bump angular versions to 14 #264

Open dmkachko opened 2 years ago

dmkachko commented 2 years ago

Refactor the project structure to comply recommendations

Stabzs commented 2 years ago

Thank you for all of your fantastic work porting to version 14! Overall this looks good although there a few minor updates that are required. I'll pull this down today and test it.

cmartost commented 1 year ago

@Stabzs Have you been able to look at this?

thomae82 commented 1 year ago

Would be great if this would be released. We have a few projects > Angular 11 with "broken" dependencies. By when will it be released? What about Angular 15?

Stabzs commented 1 year ago

@dmkachko are you able to review and complete the rest of the feedback?

dmkachko commented 1 year ago

@Stabzs Sorry accidentally pushed the next update to the same branch. I don't see too much feedback, though reverted the name of the project and urls accidentally changed.

Stabzs commented 1 year ago

@dmkachko no problem! If you make a separate branch/pr, I can make sure both get pushed out this week. Are you able to speak to this comment/question? "Where did the css transpilation move to and how is it exposed in the built package?"

Thanks!

dmkachko commented 1 year ago

@Stabzs I am sorry, just in case I am missing something, for some reason I don't see any conversations or change requests attached to the PR, and don't have anything in the mail either. Where do you see this question?

Stabzs commented 1 year ago

EDIT: Found it...the request for changes didn't submit...my fault. Sorry about that!

@dmkachko odd, not sure why that is.

https://github.com/Stabzs/Angular2-Toaster/pull/264/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

Screen Shot 2023-04-13 at 12 20 27 PM

dmkachko commented 1 year ago

@Stabzs The feedback is implemented, pls let me know if you see anything else.

selangley-wa commented 1 year ago

@Stabzs Merge this or #273 ?