search

StackDoubleFlow / CustomJSONData

MIT License
14 stars 12 forks source link

1.28 release always results in SS rank #34

Closed McLovin836 closed 1 year ago

McLovin836 commented 1 year ago

When enabling mod in BMBF and playing any song in BS 1.28, the results screen always shows SS rank, no matter what your score is

ImWoood commented 1 year ago

Will this get fixed because I have the exact same problem with this mod and the issue you mentioned was closed without a fix. It would be nice if you could do something about it because I need this mod, without many maps won't work :(

Fernthedev commented 1 year ago

Feel free to fix it then.

The issue was closed because it was a duplicate, common practice in GitHub and this is no exception.

ImWoood commented 1 year ago

Sry didn't know that. Do you have any idea what could cause this bug?

Metalit commented 1 year ago

Forgot to mention in it, but this should be fixed in https://github.com/StackDoubleFlow/CustomJSONData/pull/37

Fernthedev commented 1 year ago

Fixed by #37

Dozer58 commented 1 year ago

Anyway to download a qmod with the fixed code?

copyrightbreaker commented 9 months ago

Issue still not fixed unfortunately.

tomporter518 commented 9 months ago

Recently installed Chroma from: Beat Saber Mod Versions on my new Quest 3. Prior to installing, but with a modded Beat Saber, I got various ranks. With Chroma installed even very, very poor performance results in an SS.

GitEmulate commented 8 months ago

Still having this issue. Once again asking how to get an updated version of this mod with the fix, since the latest release is so old it's before https://github.com/StackDoubleFlow/CustomJSONData/pull/37

FoxxMD commented 7 months ago

Also experiencing this issue even with v0.19.3 and trying to use the hotfixed version in the 1.28 release results in the same issue as seen in #39

kingpanguan commented 2 months ago

same

Fernthedev commented 2 months ago

Use 1.37. 1.28 is no longer supported. Please no longer refer to this issue as its been resolved for 7 months and 3 weeks.

Click to show more [Here's a fixed qmod](https://github.com/StackDoubleFlow/CustomJSONData/releases/download/v0.19.0/custom-json-data.qmod) for those of you too stubborn to use a [version with an inenumerable amount of improvements](https://github.com/StackDoubleFlow/CustomJSONData/compare/v0.19.0...main). Apologies for the botched hotfixes.
Dozer58 commented 2 months ago

Thing is 1.28 has multiplayer mods, the new versions don't, and using the 1.28 mod installer always installed the version of JSONData that doesn't have the fix.

Thanks for the link to the fixed 1.28 qmod, people can now play multiplayer without getting SS (Although i'm not sure why it's 4x the size of the 1.28 fixed version I have and the up to date 1.37 version)

maxkoshevoi commented 2 months ago

@Fernthedev I think for Quest 1 (which I have) it's only possible to mode up to version 1.28 unfortunately.. Also https://www.questmodding.com/ mentions 1.28 as latest modable version so people with Quest 2 & 3 can stumble upon this issue as well

Thank you for providing fixed qmod file! It seems that it's intended to be installed with Scotland2, but 1.28 mods use QuestLoader, so I'm getting this error while trying to install it (repatching doesn't help since other mods use QuestLoader): image

Could you please compile fixed qmod for QuestLoader?

Dozer58 commented 2 months ago

Does this version I have work with quest loader? https://filebin.net/rybbb3l7c64ciq9g

maxkoshevoi commented 2 months ago

Does this version I have work with quest loader? https://filebin.net/rybbb3l7c64ciq9g

Yes! Thank you!! The score calculates properly now. QuestPatcher says its 0.19.3, but your file is different from the one here https://github.com/StackDoubleFlow/CustomJSONData/releases/tag/v0.19.3 No idea where you got that, but thank you!