search

StackDoubleFlow / NoodleExtensions

86 stars 12 forks source link

map data load fix #40

Closed Royston1999 closed 2 years ago

Royston1999 commented 2 years ago

This fixes the crash that Metalit and I have been getting when calling GetBeatmapDataAsync() by enabling the noodle hooks at the PinkCore API callback in the menu rather than during the scene setup

Fernthedev commented 2 years ago

This is not a fix, and instead just allows Noodle to run when it's not intended. Will be closing as this workaround is deemed not acceptable.

Metalit commented 2 years ago

How is this running when it's not intended when the hooks are only enabled on maps with the noodle requirement? It seems pretty valuable to have this crash fixed.

Fernthedev commented 2 years ago

The PR isn’t a fix in my eyes. It’s a bandaid workaround that will likely bite me in in the future. Should investigate WHY noodle hooks fix it rather than forcing it on in the menu scene.