search

StackExchange / StackExchange.Redis

General purpose redis client
https://stackexchange.github.io/StackExchange.Redis/
Other
5.89k stars 1.51k forks source link

Enable net6.0 build #2497

Closed eerhardt closed 1 year ago

eerhardt commented 1 year ago

This allows for using new APIs introduced in net6.0.

In order to enable building for net6.0, we also need to revert the thread pool changes in #1939 and #1950. This was already effectively reverted in #1992 by not building for net6.0. Now that we are building for net6.0 again, these if-defs need to be removed.

Questions:

  1. Does this need a ReleaseNotes entry? I don't think there is any user-visible affect to this change.
  2. Should net5.0 be removed? It has been end-of-life for over a year. I left it in, for now. It can be removed in the future, if we think it should be removed.

cc @NickCraver @mgravell

NickCraver commented 1 year ago

FWIW I'm good with dropping net5.0 here given it's non-LTS and EOL over a year ago - @mgravell thoughts?

0xfeeddeadbeef commented 1 year ago

Why not drop .NET Core 3.1 as well while at it?

0xfeeddeadbeef commented 1 year ago

IMHO, dropping a target framework is a kind of change that warrants bumping a minor version (at least).

NickCraver commented 1 year ago

@0xfeeddeadbeef because .NET Core 3.1 is newer and was an LTS which many more people are on for the long-term. If we're dropping an LTS, I'd agree with a minor version bump. For a non-LTS over a year past EOL I'm a lot less concerned :)