search

StackExchange / StackExchange.Redis

General purpose redis client
https://stackexchange.github.io/StackExchange.Redis/
Other
5.85k stars 1.5k forks source link

Use GlobalPackageReference for Microsoft.NETFramework.ReferenceAssemblies #2622

Closed WeihanLi closed 6 months ago

WeihanLi commented 6 months ago

use GlobalPackageReference since it's for all projects and PrivateAssets="All"

https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management#global-package-references

mgravell commented 6 months ago

Not sure I see the benefit of this - it doesn't reduce any duplication, and the existing code is perfectly clear. It seems to be a change for change's sake?

WeihanLi commented 6 months ago

We can have version and reference defined in one place, without splitting into two places

mgravell commented 6 months ago

We can have version and reference defined in one place, without splitting into two places

Which is how literally every other reference works. I'm not sure I see the benefit of changing it, honestly, other than "just because"

WeihanLi commented 6 months ago

I'm fine with it either way, thanks for the opinion