StackExchange / StackExchange.Redis

General purpose redis client
https://stackexchange.github.io/StackExchange.Redis/
Other
5.85k stars 1.5k forks source link

Is there a way to execute individual commands with FailFast behavior? #2645

Open madelson opened 5 months ago

madelson commented 5 months ago

I have some logic using the RedLock algorithm to fire commands against multiple servers and recover if some servers are down. I recently updated from 2.2.4 to 2.7.17, and some of my tests are failing because the redis client now takes much longer to return when the server is disconnected. Switching the multiplexer to use BacklogPolicy.FailFast fixes this, but in general I want the new policy, just not for these particular operations where I want to fail quickly.

Is there a recommended way to achieve this? Should I be calling IDatabase.IsConnected() before every fail fast request and bailing if that returns false or is that going to hurt performance/have different semantics? If there's no way to achieve this, would it make sense to add a CommandFlags option to support it?

The way I simulate a downed server in my tests is as follows:

Thanks for creating and maintaining this great library!

NickCraver commented 5 months ago

Since we are a multiplexed pipeline, the backlog behavior can't really be per-operation since they're sharing a queue. Effectively, it's a behavior attribute of that overall queue (per connection). If you want to have different queue behavior for a certain set of things, I'd recommend a second multiplexer with that configuration since inherently they cannot share a config here, and use logic in the app side to decide which multiplexer to send the command(s) on.

madelson commented 5 months ago

Thanks for the quick response @NickCraver .

What do you think about the option of calling IsConnected() before each request? What is the overhead of that like?

For context I'm working on a library where an IDatabase is passed to me, so I'd like to avoid requiring the caller to configure their connection in a particular way if possible.

NickCraver commented 4 months ago

@madelson I'm not sure that makes a whole lot of sense when we think in pipeline terms. For example, it can disconnected immediately after your check - a flow of things is at some point interrupted and you won't know that immediately, there will always be some delay however small. The overhead is minimal - that's a cached bool on our side, and it would make some difference, but keep in mind that it can fail after the check is all.

The CommandFlags is an open question - curious what @mgravell thinks here. It is something we could add like CommandFlags.NoBacklog or something...though that name is accurate, I don't think it's intuitive. Perhaps CommandFlags.NoBacklogIfDisconnected or some such?

@mgravell thoughts on such a thing? To my knowledge, this if the first time the request has come up, but I could imagine many other cases to utilize such a thing.