All of the replacements were empirically tested to be correct via simple programs in combination with a local redis instance.
Notably, there is one worrying nit; in testing it turns out that the IDatabase.List{Left,Right}Pop(RedisKey, long, CommandFlags) overload which I talked about in the issue can actually return null, contrary to its nullability annotations. This occurs on missing key; in that case redis replies
I briefly attempted to rectify this, but the RedisValueArrayProcessor poses a problem here, as changing it to derive
ResultProcessor<RedisValue[]?> causes the solution to light up in red, and I'd rather not mess with that as a first contribution without at least prior discussion concerning direction there.
Closes https://github.com/StackExchange/StackExchange.Redis/issues/2697.
All of the replacements were empirically tested to be correct via simple programs in combination with a local redis instance.
Notably, there is one worrying nit; in testing it turns out that the
IDatabase.List{Left,Right}Pop(RedisKey, long, CommandFlags)overload which I talked about in the issue can actually return null, contrary to its nullability annotations. This occurs on missing key; in that case redis repliesas per https://redis.io/docs/latest/commands/lpop/, which then at
https://github.com/StackExchange/StackExchange.Redis/blob/cb8b20df0e2975717bde97ce95ac20e8e8353572/src/StackExchange.Redis/ResultProcessor.cs#L1546-L1547
and later at
https://github.com/StackExchange/StackExchange.Redis/blob/cb8b20df0e2975717bde97ce95ac20e8e8353572/src/StackExchange.Redis/ExtensionMethods.cs#L339-L341
turns into a
null.I briefly attempted to rectify this, but the
RedisValueArrayProcessorposes a problem here, as changing it to deriveResultProcessor<RedisValue[]?>causes the solution to light up in red, and I'd rather not mess with that as a first contribution without at least prior discussion concerning direction there.