search

StackExchange / StackExchange.Redis

General purpose redis client
https://stackexchange.github.io/StackExchange.Redis/
Other
5.88k stars 1.51k forks source link

Added SetUnion, SetIntersect and SetDiff to IDatabase. All of them are used SetCombine method #2708

Closed mohsenbgi closed 5 months ago

mohsenbgi commented 5 months ago

Added SetUnion, SetIntersect and SetDiff to IDatabase. All of them are used SetCombine method

NickCraver commented 5 months ago

Hey there! I'm curious what functionality is missing in the current APIs here - can you please explain what's not current covered by the SetCombine(AndStore)(Async) methods today?

mohsenbgi commented 5 months ago

Hi there, I think that if Redis commands are named intuitively, they can be easier to use and enhance the readability of the code.

NickCraver commented 5 months ago

I hear you, and that's certainly a good argument I agree with for any new APIs being added to be intuitive as always, but adding duplicate commands creating both confusion and a lot of overhead does not further that goal.

If we have thoughts on how to make the existing APIs more discoverable, certainly open to options there but we shouldn't add dozens of duplicates to the surface area to achieve that :)

mohsenbgi commented 5 months ago

You're right. Thanks for taking the time to review 🙌.