search

StackExchange / Stacks

Stack Overflow’s Design System
https://stackoverflow.design
MIT License
607 stars 89 forks source link

refactor(focus-ring): use focus-ring CSS vars for focus states only #1609

Closed dancormier closed 7 months ago

dancormier commented 7 months ago

STACKS-532

@giamir I'm curious to get your thoughts on two things:

1) Naming: I went with translucent because I figured that was descriptive enough but I'm wondering if you can think of a better name to go with for the added css variables 2) When I update the less snapshots locally, each instance of : in selectors gets prefixed with \\\\. When the workflow runs on GitHub, it expects "\". Any idea of why this happens and how to resolve? (This is a minor issue so please don't spend too much time on this!)

netlify[bot] commented 7 months ago

Deploy Preview for stacks ready!

Name Link
Latest commit 35901b12628d7aa24781254ffd752f63ea8b95ed
Latest deploy log https://app.netlify.com/sites/stacks/deploys/65afe55f32c5b3000859d9d1
Deploy Preview https://deploy-preview-1609--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dancormier commented 7 months ago

I remember upgrading from vitest 0.x.x to 1.x.x resolved some of those weird backslashes appearing in the snapshots. Have you tried to nuke the node_modules and do a fresh install?

Nuking and reinstalling deps fixed the issue 🎉 @giamir thank you!