StackExchange / Stacks

Stack Overflowโ€™s Design System
https://stackoverflow.design
MIT License
610 stars 90 forks source link

test(topbar): add visual regression tests #1624

Closed dancormier closed 8 months ago

dancormier commented 8 months ago

STACKS-551

This PR adds tests for the topbar component. My hope is that we can get these tests merged, then pull these changes into the PPCP refactor to give us confidence that the refactor doesn't introduce regressions ๐Ÿคž After that, I'd like to start the focus style updates on the newly refactored topbar Less.


@giamir when you have a moment, can you look into why the searchbar is rendering too high in test images? I've exhausted anything I can come up with (I even tried just rendering the markup from our docs site and the searchbar is still misaligned). No rush on this.

netlify[bot] commented 8 months ago

Deploy Preview for stacks ready!

Name Link
Latest commit 41bdf5cac1908a65e9dcd862f36a8492e143f46e
Latest deploy log https://app.netlify.com/sites/stacks/deploys/65bbc966a3e58e00083b7306
Deploy Preview https://deploy-preview-1624--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.