StackExchange / Stacks

Stack Overflow’s Design System
https://stackoverflow.design
MIT License
602 stars 89 forks source link

fix(test): ensure `includeNullModifier` value is honored #1638

Closed dancormier closed 5 months ago

dancormier commented 5 months ago

After having visual failures of test(select): add a11y, visual tests #1498 after it had been updated with the latest test changes in develop, I realized something was not working as expected.

Turns out that we're not fully honoring the includeNullModifier option for secondary and global modifiers (this bug predates the recent test changes). This PR fixes that bug.

netlify[bot] commented 5 months ago

Deploy Preview for stacks ready!

Name Link
Latest commit 9e7865da50e2a2f7e6f2321d43cbd3f60f487f45
Latest deploy log https://app.netlify.com/sites/stacks/deploys/65c3e22226af8700087b4553
Deploy Preview https://deploy-preview-1638--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 5 months ago

Deploy Preview for stacks ready!

Name Link
Latest commit 78517136f47188544dc68e9f6733318edb2797b0
Latest deploy log https://app.netlify.com/sites/stacks/deploys/65c3e22f0de35700082608c6
Deploy Preview https://deploy-preview-1638--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.