StackExchange / Stacks

Stack Overflow’s Design System
https://stackoverflow.design
MIT License
602 stars 89 forks source link

refactor(spacing): generate spacing atomic classes programatically #1654

Closed dancormier closed 4 months ago

dancormier commented 4 months ago

This PR expands on https://github.com/StackExchange/Stacks/pull/1652 and closes https://github.com/StackExchange/Stacks/issues/1653


Spacing class generation is prone to bugs and accidental omissions. This PR make generation of spacing (and incidentally, positioning) atomic classes and documentation more programmatic.

netlify[bot] commented 4 months ago

Deploy Preview for stacks ready!

Name Link
Latest commit 1cea779bb93f21dcc99eec593d3cb24885fedb29
Latest deploy log https://app.netlify.com/sites/stacks/deploys/65d538768f70720008132852
Deploy Preview https://deploy-preview-1654--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Deploy Preview for stacks ready!

Name Link
Latest commit 5e1bfb033d8deff8048216eb468103c6bdd151e3
Latest deploy log https://app.netlify.com/sites/stacks/deploys/65e1fcc6eddc020008e1a524
Deploy Preview https://deploy-preview-1654--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

giamir commented 4 months ago

This refactor makes a lot of sense to me. I just glanced at the PR and left a comment. I will do a full review once you mark the PR as ready for review. Thanks @dancormier