StackExchange / Stacks

Stack Overflow’s Design System
https://stackoverflow.design
MIT License
602 stars 89 forks source link

fix(button): ensure button gains bg color when focused #1671

Closed dancormier closed 4 months ago

dancormier commented 4 months ago

This PR ensures that the button gains a background color when focused as expected.

πŸ”— Button component in deploy preview


In the process of building the accessibility docs page, I noticed that button variants with no modifiers were not showing the intended background color when focused:

Expectation

image image image

Reality

image image image

netlify[bot] commented 4 months ago

Deploy Preview for stacks ready!

Name Link
Latest commit da3a29ff1bbfe112cbd5b12e509ae6b6a81dcd29
Latest deploy log https://app.netlify.com/sites/stacks/deploys/65eb9bc181056300089ae8d7
Deploy Preview https://deploy-preview-1671--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dancormier commented 4 months ago

@giamir thanks for the speedy review! I've added an issue for testing interaction states as you suggested