Closed hamvocke closed 3 months ago
CGuindon
commented
3 months ago I had previously figured out the color combos needed for the comment box — so these should work for the blue notice. To do the other colors, we'll some design time and that's not going to happen until the end of this quarter (we have bug bash I can assign this to someone). You can also verify if the the other colors work with the same color stops but I bet there will be issues with red and yellow.
dancormier
commented
3 months ago Merging this since the changes here are really just from https://github.com/StackExchange/Stacks/pull/1678 which has been reviewed and approved. 🚢
netlify[bot]
commented
3 months ago | Name | Link |
|---|---|
| Latest commit | fa2e4699fd3a8e90ea1807278df0275c9bbfedcf |
| Latest deploy log | https://app.netlify.com/sites/stacks/deploys/65f327946f41a40008ca16e7 |
| Deploy Preview | https://deploy-preview-1677--stacks.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
The
s-noticecomponent currently has insufficient color contrast when used in combination with inlinecodeelements. Here's what it looks like in dark mode, for example:I'm opening this PR to give us a playground to discuss and fix this problem. I tried to play around with various color combinations for the background and text colors myself but quickly realized that I've got no idea what we're aiming for from a visual perspective. I could tweak the colors until I hit the right color contrast, obviously, but I really need some guidance on the visual design, too.