StackExchange / Stacks

Stack Overflow’s Design System
https://stackoverflow.design
MIT License
610 stars 90 forks source link

docs(figma): obfuscate figma links under okta auth #1712

Closed dancormier closed 4 months ago

dancormier commented 5 months ago

STACKS-608

This PR obfuscate figma links under okta auth.

See also:

To test

Checkout pages like Color fundamentals or Box Shadow and notice that the figma links are now forcing you to go through okta auth before being revealed.

netlify[bot] commented 5 months ago

Deploy Preview for stacks ready!

Name Link
Latest commit cb96b386d2ba942a3733460b72766216c347f1d3
Latest deploy log https://app.netlify.com/sites/stacks/deploys/665f2b4dd138cc0007ab61a3
Deploy Preview https://deploy-preview-1712--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

giamir commented 4 months ago

@CGuindon can you give me a thumbs up if now the figma links make you go through the okta flow before being redirected to the actual files. Thanks

Sidenote It would be nice to cleanup/organize a bit the design system figma files. In the process of mapping the redirects I noticed that there is quite a bit of inconsistencies across the files (some are even outdated I think). Shane started to clean up a bit but unfortunately he did not have the time to get very far.

CGuindon commented 4 months ago

For the sidenote: If there's a ticket in the design backlog already for this we can leave it, if not can you create one? Add any notes you have about some of the inconsistencies you saw.

giamir commented 4 months ago

The first time I clicked the Color fundamentals Figma link, it forced me to log into okta (yay!) but after passing login, the redirect failed: Screenshot 2024-06-04 at 8 47 13 AM

Once logged in though, if I click on the link again, it redirects correctly to Figma. If this is too tricky to fix, it's not that big of a deal since you just have to click the link twice the first time.

@CGuindon I am struggling to reproduce this somehow in my machine. This is the flow I consistently get. 🤔

https://github.com/StackExchange/Stacks/assets/6231616/c9dcb0e0-932e-4813-ae35-625ba2daaa9f

CGuindon commented 4 months ago

@giamir I was getting the error right before the Figma loading redirect screen in your flow. I just tried it again and I didn't see that error... soooo I'm tempted to say it might have been a weird edge case? Either way, still doesn't feel that big, I'll approve and if the issue comes up more often after merging we can open a new bug ticket.