StackExchange / Stacks

Stack Overflow’s Design System
https://stackoverflow.design
MIT License
602 stars 90 forks source link

chore(links): update visited links colors w/ a11y considerations #1740

Open dancormier opened 1 month ago

dancormier commented 1 month ago

STACK-481

In https://github.com/StackExchange/Stacks/pull/1735, we updated visited link styles. @giamir later pointed out that we should consider WCAG SC 1.4.1, which suggests that links within otherwise unlinked text needs to be differentiated from surrounding text either by some means other than color (underlining, bolding, etc) or differentiate significantly by both hue and lightness (see comment). Also see A11Y-108

Because link styles may require more work/consideration than was performed in https://github.com/StackExchange/Stacks/pull/1735, we decided to revert that PRs merge to avoid shipping a half-baked change. In this PR, we'll resolve any lingering accessibility issues with link color and then ship it out.

cc @giamir @CGuindon

netlify[bot] commented 1 month ago

Deploy Preview for stacks ready!

Name Link
Latest commit 0d75fc53d7485b2b053ec8c189a46a50cb41dc91
Latest deploy log https://app.netlify.com/sites/stacks/deploys/6650bae07d75f700083d0596
Deploy Preview https://deploy-preview-1740--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.