StackExchange / Stacks

Stack Overflow’s Design System
https://stackoverflow.design
MIT License
602 stars 90 forks source link

docs(a11y): document usage of ARIA landmarks across our products #1752

Closed giamir closed 4 weeks ago

giamir commented 4 weeks ago

STACKS-614

This PR documents the usage of ARIA landmarks in our accessibility page.

Furthermore it adjusts landmarks issues across our docs.

How to test

Sidenote: This PR is also adding the aria-current="page" to the selected item in the global and main navigations.

netlify[bot] commented 4 weeks ago

Deploy Preview for stacks ready!

Name Link
Latest commit 7b232b0818eab00f5bd2c5131a0e1d91dacc77e6
Latest deploy log https://app.netlify.com/sites/stacks/deploys/66605e7593bb4c0008b7452a
Deploy Preview https://deploy-preview-1752--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

giamir commented 4 weeks ago

Overall looks good to me. I noticed the Main navigation does appear twice though (because it has a duplicated as 'guessed') — not sure if that's supposed to happen or not.

Screenshot 2024-06-05 at 11 41 14 AM

The plugin has this feature where it tries to guess if an area is a landmark and it does not really work well. It should be turned off for us developers/designers I guess. You can do that by clicking the preferences section of the plugin

Screenshot 2024-06-06 at 09 39 16