search

StackExchange / dnscontrol

Infrastructure as code for DNS!
https://dnscontrol.org/
MIT License
3.07k stars 389 forks source link

Bind driver returning 0 for all TTLs #16

Closed mhenderson-so closed 7 years ago

mhenderson-so commented 7 years ago

Any zone that uses the Active Directory driver is returning a 0 for the TTL when reading the zone for diffing. This results in all the AD records being replaced every time dnscontrol is run.

E.g: [Step 1/1] MODIFY A example.com: (10.7.3.28 0) -> (10.7.3.28 300)

captncraig commented 7 years ago

Issue is in the bind driver. When the default value of 300 is found, the driver is replacing it with 0. Not what should happen. https://github.com/StackExchange/dnscontrol/blob/master/providers/bind/bindProvider.go#L74

captncraig commented 7 years ago

Fixed.