Open nvanlaerebeke opened 11 months ago
Sorry for the long delay!
I'd be glad to walk you through this!
The way that integration tests work is to make a change then do a preview to see that the change worked as expected. Think of each test as building a dnsconfig.js file. The first step is to (do the equivalent of) "dnscontrol push" to make the change. The second step is to do (the equivalent of) "dnscontrol preview" which should result in "0 changes needed". If any changes were needed, the update wasn't done correctly. Those unexpected changes are listed as "UNEXPECTED #n" where n starts at 0 and increments.
The above error message is the 2nd push. Instead of getting "0 changes needed", the diff engine returned 1 change. UNEXPECTED #0
is the first (0th) change:
integration_test.go:279: UNEXPECTED #0: ± MODIFY testcname.example.com CNAME (www.google.com.example.com. ttl=600) -> (www.google.com. ttl=600)
The preview found a CNAME at testcname.example.com
which pointed to www.google.com.example.com.
but needs to be corrected to point to www.google.com.
.
That indicates that the original "push" created the CNAME without the trailing "." thus GoDaddy added .example.com.
.
In other words, the API is expecting you to add a "." to the end of the CNAME's target.
I see there are failures for MX, NS and other records that have a target that is a hostname, just like CNAME.
Hope that helps!
P.S. Try adding -v
and -verbose
to your integration test for more verbose output: go test -v -verbose -provider GODADDY
Friendly ping?
Unfortunately I haven't found the time to work on this, had things come in between (like planning my wedding).
Still want to finish this as every time I make a DNS change I'm annoyed at having to do it manually, their interface is fairly annoying to use IMO.
Hoping to find some time between Christmas and new year, have a couple of days off work that period.
No worries! Just wanted to check in and let you know I'm available if you need help.
wedding > dnscontrol
Congrats on your recent nuptials! I hope marriage brings you the joy that it has brought my family!
Best, Tom
I've been trying my hand at creating a provider for godaddy where I have my domains.
Need some help with the implementation, gotten some things working already but still have quite a few tests failing.
Have no GO experience at all, this is the first time doing anything in the language but did somewhat manage I think.
The fork can be found here: https://github.com/nvanlaerebeke/dnscontrol/tree/feature/godaddy
Trying to get all the integration tests working, I'm having some issues with the CNAME and MX records now where the domain is being appended to the data, example the output for the "Create_a_CNAME" test:
The CNAME record is correctly created, but for some reason it checks with the 'www.google.com.' during the verification.
It's implemented with
diff2
just as mentioned in the docs.I'm working on this on and off when I have some brain power left after work so apologies if progress isn't super fast.
Current progress on the tests