search

StackExchange / dnscontrol

Infrastructure as code for DNS!
https://dnscontrol.org/
MIT License
3.13k stars 397 forks source link

dnscontrol should not crash on unknown DNS record types #273

Closed philhug closed 6 years ago

philhug commented 6 years ago

This is supported on Cloudflare and when they exist, the following error occurs and dnscontrol aborts: Unimplemented rtype SPF

Expected behaviour: 1) ignore unknown records 2) delete unknown records 3) abort synchronisation (current behaviour)

Same issue for LOC records.

tlimoncelli commented 6 years ago

It is my understanding that the SPF retype (99) is obsolete and TXT records should be used instead:

https://stackoverflow.com/a/13971793/71978 -- Sent from Gmail Mobile

philhug commented 6 years ago

I agree. In that case deleting them from cloudflare zone would be the best solution IMO.

tlimoncelli commented 6 years ago

I believe it deletes SPF records now.

LOC records should be easy to support. https://stackexchange.github.io/dnscontrol/adding-new-rtypes makes it easy.

philhug commented 6 years ago

ok, I renamed the issue accordingly.

tlimoncelli commented 6 years ago

I'm curious about LOC records. They were proposed in 1996 and never got traction. Do you know any provider that supports them? Do you actively use them?

philhug commented 6 years ago

the records are supported by cloudflare. I'm not using them.

tlimoncelli commented 6 years ago

Crashing when unrecognized records appear is how the system was designed. The system should crash with an error message that explains why.

We're focusing on features that have direct production needs, not chasing every provider feature. If someone needs a record type supported, we encourage them to add the feature and submit a PR. We make it pretty easy to do so.

We do have some ideas about supporting the ability to ignore certain labels, which will be a decent workaround for this.

I'm going to close this issue. We can reopen it in the future if needed.