StackExchange / dnscontrol

Infrastructure as code for DNS!
https://dnscontrol.org/
MIT License
3.07k stars 389 forks source link

Difference in preview stdout with 4.12.3 #3040

Closed ajh0912 closed 1 month ago

ajh0912 commented 2 months ago

Describe the bug The dnscontrol preview output in 4.12.3 is different from 4.12.2. 4.12.3 outputs "DOMAIN: number of resource records zone name" in preview text.

Is this intended? The release states "This release makes exactly one change: Adds a CF_SINGLE_REDIRECT() feature". I can understand if this functionality was added on purpose, but there's no mention/docs.

It looks like this might have been introduced here in postprocess.go.

To Reproduce Issue present in 4.12.3, Linux and Windows.

PS C:\> dnscontrol version
DNSControl version 4.12.3
PS C:\> dnscontrol preview --creds '!op inject -i creds.json.tpl'
DOMAIN: 13 example.com
DOMAIN: 6 example.net
******************** Domain: example.com
******************** Domain: example.net
Done. 0 corrections.

Expected behavior

PS C:\> dnscontrol version
DNSControl version 4.12.2
PS C:\> dnscontrol preview --creds '!op inject -i creds.json.tpl'
******************** Domain: example.com
******************** Domain: example.net
Done. 0 corrections.

DNS Provider

Additional context I do some parsing of the text output from a dnscontrol preview, to generate a summary of expected changes. I know that JSON reports are possible with push - but I need a summary before any changes are made. I noticed this stdout difference due to errors in my parsing.

tlimoncelli commented 2 months ago

Ah! That was not intended. That's a debugging statement that I meant to remove before. My apologies!

I'll remove it in a bugfix release later today.

ajh0912 commented 1 month ago

Thanks!